Add mazerunner scenarios for stopping/resuming a session #430
+147
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a session is stopped, no session information should be present in error payloads.
Cawllec
reviewed
Feb 19, 2019
| And the request 1 is valid for the error reporting API | ||
| And the request 2 is valid for the error reporting API | ||
| And the payload field "events.0.session.events.handled" equals 1 for request 1 | ||
| And the payload field "events.0.session.events.handled" equals 2 for request 2 |
There was a problem hiding this comment.
I'm going to add a comparison between UUID's and start times here
|
What would happen if you paused sessions then called |
Cawllec
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Verifies that no session information is present in an error payload when the session is stopped, and that the previous session information is used when the session is resumed.
This PR adds mazerunner test coverage. See #429 for the full implementation and explanation.